Skip to content

Conversation

@thecalamiity
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

This PR adds more flexible configuration to the use-baseline rule by introducing the allowFunctions, allowMediaConditions, and allowPropertyValues options. These options let users selectively permit specific functions, media conditions, and property values that are otherwise reported as non-baseline features.

What changes did you make? (Give an overview)

  • Added allowFunctions, allowMediaConditions, and allowPropertyValues options to the rule schema and implementation.
  • Updated documentation with examples.
  • Added corresponding tests.

Related Issues

Fixes #298

Is there anything you'd like reviewers to focus on?

@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 27, 2025
@Tanujkanti4441 Tanujkanti4441 moved this from Needs Triage to Implementing in Triage Oct 27, 2025
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like another review before merging.

@Tanujkanti4441 Tanujkanti4441 moved this from Implementing to Second Review Needed in Triage Oct 28, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit e8dc57d into eslint:main Oct 29, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Rule Change: Add more allow* options to use-baseline rule

4 participants