Docs: pluralize 'line' to 'lines' in max-lines-per-function description #14115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
mdjermanovic
added
accepted
There was a problem hiding this comment.
Hi @trevinhofmann, thanks for the PR!
The change looks good to me. Just to double-check, have you signed the CLA? (I believe you already signed before, I'm not sure why the status on the check is pending).
|
Note to the merger: the commit message should start with |
nzakas
approved these changes
Feb 17, 2021
mdjermanovic
approved these changes
Feb 18, 2021
snitin315
approved these changes
Feb 18, 2021
This was referenced Mar 5, 2021
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Merged
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I fixed one word in the description of the
max-lines-per-functionrule by pluralizing it.Is there anything you'd like reviewers to focus on?
Please read the rule description to ensure grammar is now correct.