feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converting to draft - not sure why the test failed. |
aladdin-add
force-pushed
the
feat/node.js-18
branch
3 times, most recently
from
e39b3dd
to
b07ae92
Compare
|
Maybe a result of the Acorn bugs? |
|
Where are we on this? |
|
blocked by #590, and it's blocked by acorn. |
|
Is there an Acorn issue we can track? |
|
seems no, will file one later. |
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
aladdin-add
force-pushed
the
feat/node.js-18
branch
from
b07ae92
to
491b7fa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: eslint/eslint#17595
blocked by #590