feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24
#696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
previously approved these changes
Sep 25, 2025
Member
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
LGTM, thanks! Waiting for another review.
1 task
Member
|
there is a conflict now. |
mdjermanovic
force-pushed
the
node-versions-v10
branch
from
0b5fb12 to
31b5cf2
Compare
Member
Author
Resolved now. |
fasttime
approved these changes
Oct 18, 2025
Contributor
|
@mdjermanovic does this change mean that espree 10 (and thus, eslint 9) can't ever support ecmaVersion 2025, which includes import assertions? |
Member
Author
|
espree 10 and eslint 9 already fully support ecmaVersion 2025. |
Contributor
|
Thanks; I clarified that in the discord. It turns out it's a different issue with eslint; i'll keep looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Aligns supported Node.js versions with ESLint v10.
What changes did you make? (Give an overview)
Updated
package.jsonof theespree,eslint-scope, andeslint-visitor-keyspackages to require:This drops support for Node.js 18.
Also updated CI configs and docs accordingly.
Related Issues
Refs eslint/eslint#19969
Is there anything you'd like reviewers to focus on?
Did I miss any places that should be updated?