-
Notifications
You must be signed in to change notification settings - Fork 80
fix: false positives in no-reversed-media-syntax
#521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: false positives in no-reversed-media-syntax
#521
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…lse-positives-in-no-reversed-media-syntax
…lse-positives-in-no-reversed-media-syntax
| }, | ||
| ], | ||
| }, | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case isn't related to this change, but the test for the Image node within a FootnoteReference node was missing, so I've added one.
mdjermanovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
Which language are you using?
CommonMark and GFM.
What did you do?
I expected
no-reversed-media-syntaxnot to report occurrences insideImage,ImageReference, orLinkReference, but it does.Image,ImageReference, andLinkReferenceare nodes where aLinknode using the[]()syntax cannot appear, so these are false positives.What did you expect to happen?
I expect no false positives to occur in
Image,ImageReference, orLinkReferencenodes.Link to minimal reproducible Example
The following Markdown code may help identify the problem:
What changes did you make? (Give an overview)
In this PR, I've fixed false positives in
no-reversed-media-syntaxrule.Image,ImageReference, andLinkReferenceare nodes where aLinknode using the[]()syntax cannot appear, so these are false positives.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A