Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: Add @types/eslint dependency #105

Closed
2 of 6 tasks
danielrentz opened this issue Aug 13, 2024 · 1 comment · May be fixed by #106
Closed
2 of 6 tasks

Change Request: Add @types/eslint dependency #105

danielrentz opened this issue Aug 13, 2024 · 1 comment · May be fixed by #106
Labels
enhancement New feature or request

Comments

@danielrentz
Copy link

Which packages would you like to change?

  • @eslint/compat
  • @eslint/config-array
  • @eslint/core
  • @eslint/migrate-config
  • @eslint/object-schema

What problem do you want to solve?

Prevent type errors when using this plugin in TS files. Follow up from #104.

What do you think is the correct solution?

This package exports type definitions in d.ts files referencing types from the eslint package. Therefore, it should include @types/eslint as public dependency.

As stated in #104, this package should work with @types/eslint v8 and v9, therefore the dependency should be just "*" as done in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/eslint__js/package.json#L9

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response
@danielrentz danielrentz added the enhancement New feature or request label Aug 13, 2024
danielrentz added a commit to danielrentz/rewrite that referenced this issue Aug 13, 2024
@danielrentz
feat: make @types/eslint dependency public
8b732e5 
fixes eslint#105
@danielrentz danielrentz mentioned this issue Aug 13, 2024
Draft
1 task
@nzakas
Copy link
Member

nzakas commented Aug 13, 2024

Let's keep the conversation on #104. There's no need for a separate issue.

@nzakas nzakas closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make @types/eslint dependency public danielrentz/rewrite
2 participants
@nzakas @danielrentz