Memory leak

[bmah888]

From devzone.my on February 15, 2013 04:47:36

[src/iperf_api.c:1179]: (error) Memory leak: tcp
[src/locale.c:104]: (error) syntax error
[src/locale.c:334]: (error) Invalid number of character ({) when these macros are defined: '__cplusplus'.

Original issue: http://code.google.com/p/iperf/issues/detail?id=60

[bmah888]

From jef.poskanzer on February 15, 2013 16:15:31

The two errors in locale.c were easily fixed, but I'm surprised that your compiler noted them. It does syntax checking inside #ifdefs that are not currently defined? That seems unusually persnickety. I like persnickety.

The supposed memory leak remains a mystery.

[bmah888]

From devzone.my on February 15, 2013 16:29:08

[src/units.c:90]: (portability) scanf without field width limits can crash with huge input data on libc versions older than 2.13-25. Add a field width specifier to fix this problem:
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
int a;
scanf("%i", &a);
return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out

[bmah888]

From jdugan@es.net on February 15, 2013 16:30:51

Is this analysis coming from valgrind or something?

[bmah888]

From devzone.my on February 15, 2013 16:33:36

@jdu,

Yes cppcheck, http://sourceforge.net/apps/trac/cppcheck/

[bmah888]

From devzone.my on February 15, 2013 16:37:26

[src/iperf_api.c:1179]: (error) Memory leak: tcp
[src/iperf_api.c:1680]: (debug) inconclusive leak of sp: ; alloc ; use ; if return ; return use ; }
[src/iperf_api.c:769]: (debug) uninitialized variables: bailout. can't determine if this condition can be false when previous condition is false: (Nwrite(test.ctrl_sck,&test.state,1,SOCK_STREAM)<0)
[src/iperf_api.c:1232]: (debug) uninitialized variables: bailout. can't determine if this condition can be false when previous condition is false: (test.stats_timer)

[bmah888]

From bltierney@es.net on March 12, 2013 15:46:24

Owner: japoskanzer@lbl.gov
Labels: Milestone-3.0-Release

[bmah888]

From bltierney@es.net on May 08, 2013 14:33:51

was not able to replicate
problem may be fixed.

Status: WontFix