-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embuild
shouldn't require git
or .git
to exist in order to build the project
#81
Comments
Here's a pull request that was already reviewed and requires just a little love from somebody to get merged. (As in If you would like to own it, we can have this issue fixed. What I would suggest is to clone / fork |
And the corresponding PR to |
Awesome, I'll give it a shot |
@knarkzel Sorry - I've deleted your post. You know it could be anything as to why the previous contributor has not reacted. Let's concentrate on owning and fixing the PR instead. :) |
Ait, so I tried out these patches:
Output of Still get the same error, am I missing something obvious?
Is it this |
|
|
It still thinks it's managed despite having this. |
Well you might have to dig deeper. As in setting |
Hmm lets see...
|
I must be failing to patch something because the PR looks good |
Trying this: Gives:
Adding
|
|
It seems the pull request fixed one issue, but there's several other places that must be fixed |
Maybe the relevant question here is... is |
By the way... what is it with *nix that I cannot automatically clone a git repo and then just use it? |
It's possible, just not recommended. Everything in |
I'll take another look later |
Got the same issue (with managed disabled) when using shell that lets
|
This is the shell: {
inputs = {
nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
esp-dev = {
url = "github:thiskappaisgrey/nixpkgs-esp-dev-rust";
inputs.nixpkgs.follows = "nixpkgs";
};
};
outputs = {
self,
nixpkgs,
esp-dev,
}: let
pkgs = import nixpkgs {
system = "x86_64-linux";
overlays = [ esp-dev.overlay ];
};
in {
devShells.x86_64-linux.default = pkgs.mkShell {
buildInputs = with pkgs; [
gcc-riscv32-esp32c3-elf-bin
openocd-esp32-bin
# Tools required to use ESP-IDF.
git
wget
gnumake
flex
bison
gperf
pkg-config
cmake
ninja
ncurses5
python3
python3Packages.pip
python3Packages.virtualenv
];
shellHook = ''
export ESP_IDF_VERSION="v4.4"
export LD_LIBRARY_PATH="${pkgs.lib.makeLibraryPath [ pkgs.libxml2 pkgs.zlib pkgs.stdenv.cc.cc.lib ]}"
export LIBCLANG_PATH=${pkgs.llvmPackages.libclang.lib}/lib
'';
};
};
} |
Might've forgotten to remove the patch, trying again.. 😆 |
I think you should try to confirm/deny this first. |
Tried it where I let |
You need to git clone esp idf ONLY and then try to build something with it. Like a C program. If this does not work out of the box on *nix, whatever else we try to do in the Rust crates won't work either, as they automate exactly that. |
When trying following in NixOS, it fails because this crate expects
.git
to exist for$ESP_IDF
: https://github.com/knarkzel/hello-esp32c3The text was updated successfully, but these errors were encountered: