Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self-hosted runners and HIL tests for all supported devices #1332

Closed
7 tasks done
jessebraham opened this issue Mar 21, 2024 · 9 comments
Closed
7 tasks done

Add self-hosted runners and HIL tests for all supported devices #1332

jessebraham opened this issue Mar 21, 2024 · 9 comments
Assignees
Labels
CI Continuous integration/deployment tests Unit, Integration, or Hardware-in-Loop Testing

Comments

@jessebraham
Copy link
Member

jessebraham commented Mar 21, 2024

Currently we have HIL tests running on some devices and not others. Obviously, we would eventually like to have full coverage. For various reasons this is not possible at this specific point in time, but we'll get there.

@jessebraham jessebraham added CI Continuous integration/deployment tests Unit, Integration, or Hardware-in-Loop Testing labels Mar 21, 2024
@SergioGasquez SergioGasquez self-assigned this Mar 22, 2024
@SergioGasquez SergioGasquez moved this from Todo to In Progress in esp-rs Mar 22, 2024
@jessebraham jessebraham added the status:in-progress This task is currently being worked on label Apr 3, 2024
@jessebraham
Copy link
Member Author

Work is underway on adding a runner for the ESP32-S3, however we're having some strange issues with that unfortunately, so it will likely be delayed.

Next, @SergioGasquez will work on getting a runner set up for the ESP32-C2.

@SergioGasquez
Copy link
Member

Next, @SergioGasquez will work on getting a runner set up for the ESP32-C2.

We won't be able to make changes in our lab, hence we won't be able to set up the ESP32-C2 or fix the ESP32-S3 runners until the week starting by March 15. The reason is that the lab manager will take some vacations, and he'll attend embedded world.

@SergioGasquez
Copy link
Member

SergioGasquez commented Apr 16, 2024

When adding the new targets, we may need to modify the pins that are currently being used or add some cfgs to use different pins based on the target.

Currently, installed devkits:

Missing devkits:

  • ESP32-DevKitC Pinout
    • JTAG Pins: 12, 13, 14, 15
    • Available GPIOs: 1, 2, 3, 4, 6, 7, 8, 9, 10, 11, 16, 17, 18, 19, 21, 22, 23, 25, 26, 27, 32, 33, 34, 35, 36, 39
  • ESP8684-DevKitM-1 Pinout
    • JTAG Pins: 4, 5, 6, 7
    • Available GPIOs: 0, 1, 2, 3, 9, 10, 18, 20
  • ESP32-S2-DevkitC-1 Pinout
    • JTAG Pins: 39, 40, 41, 42
    • Available GPIOs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 33, 34, 35, 37, 38, 43, 44

Available GPIOs ignore JTAG (if being used) and strapping pins.
The following pins are available for all those devkits: 2, 3
Pins that are available in most of the devkits:

  • GPIO 5 is availale in all but ESP32
  • GPIO 6, 7 and 8 are available in all but H2 and C2
  • GPIO 18 is available in all but H2.

@SergioGasquez
Copy link
Member

Did a round of local testing and here are the status udpate for all the targets:

@SergioGasquez
Copy link
Member

We are not able to add new targets until we resolve our out-of-memory issues, see #1470 (comment)

@jessebraham
Copy link
Member Author

With #1513 merged we have restored our HIL pipeline to working order (I hope 😁).

Only remaining targets at this point are the ESP32 and ESP32-C2, both are which are in-progress to varying degrees.

@SergioGasquez
Copy link
Member

SergioGasquez commented May 2, 2024

Only remaining targets at this point are the ESP32 and ESP32-C2, both are which are in-progress to varying degrees.

ESP32-C2 can run the test suite locally, we will try to set up the self-hosted-runner in the upcoming weeks. As for ESP32, we still need to improve probe-rs as it currently can't flash the tests (probe-rs/probe-rs#2354)

@SergioGasquez
Copy link
Member

ESP32-C2 HIL tests were just added! we are just missing ESP32, which is blocked due to probe-rs/probe-rs#2354

@jessebraham jessebraham added status:blocked Unable to progress - dependent on another task and removed status:in-progress This task is currently being worked on labels Jul 8, 2024
@MabezDev MabezDev added status:in-progress This task is currently being worked on and removed status:blocked Unable to progress - dependent on another task labels Aug 27, 2024
@SergioGasquez
Copy link
Member

SergioGasquez commented Sep 6, 2024

With #1977 merged, all our devices are covered in HIL! There are still a few tests disabled for some targets, see #1524

@github-project-automation github-project-automation bot moved this from In Progress to Done in esp-rs Sep 6, 2024
@SergioGasquez SergioGasquez removed the status:in-progress This task is currently being worked on label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration/deployment tests Unit, Integration, or Hardware-in-Loop Testing
Projects
Archived in project
Development

No branches or pull requests

3 participants