Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce / eliminate cache misses in interrupt handling #1747

Closed
2 tasks
bjoernQ opened this issue Jul 4, 2024 · 2 comments · Fixed by #2331
Closed
2 tasks

Reduce / eliminate cache misses in interrupt handling #1747

bjoernQ opened this issue Jul 4, 2024 · 2 comments · Fixed by #2331
Assignees
Labels
performance Performance seems to be not as good as it could be
Milestone

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Jul 4, 2024

Follow up on #1162 - there are some more insights in the linked issue

Remaining tasks

  • Replace consts this static's if they're referenced in interrupt handling code
  • Put jump tables in RAM
    • Linker magic to place them in RAM on a best effort basis

There is even more to put into RAM to avoid hitting flash. To really see where code accesses flash its best to look at disassembled code

We need to make this opt-in since it will decrease remaining useable RAM which might be a problem for some applications.

Given we don't want to introduce more features this means need #1111 first

@bjoernQ bjoernQ added the performance Performance seems to be not as good as it could be label Jul 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Jul 4, 2024
@MabezDev
Copy link
Member

Now with some configuration options we can opt into placing more of these things into IRAM

@bugadani
Copy link
Contributor

bugadani commented Sep 26, 2024

We might want to optimize IRAM code to size. The attribute exists in nightly, so if we want a config to enable nightly-specific features we can do this automagically for all IRAM code.

@tom-borcin tom-borcin added this to the 0.22.0 milestone Oct 7, 2024
@bjoernQ bjoernQ self-assigned this Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance seems to be not as good as it could be
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants