Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MultiwriteNorFlash marker trait on esp-storage::FlashStorage #2473

Closed
yanshay opened this issue Nov 6, 2024 · 3 comments
Closed

Comments

@yanshay
Copy link
Contributor

yanshay commented Nov 6, 2024

Motivations

embedded-srorage defined this trait and various crates are using it (sequential-storage).
w/o it these crates can't be used.
from esp-rs/esp-storage#39 it seems esp32 flash supports the functionality represented by this trait.
I can do that myself and submit a PR but want to verify this is indeed the case.

Solution

Just add the mentioned trait to FlashStorage (when nor-flash feature toggle is enabled)

@yanshay yanshay added the status:needs-attention This should be prioritized label Nov 6, 2024
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Nov 6, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 7, 2024

Yes implementing the MultiwriteNorFlash marker should be fine for all our chips

@yanshay
Copy link
Contributor Author

yanshay commented Nov 7, 2024

Submitted PR #2478

@MabezDev MabezDev removed the status:needs-attention This should be prioritized label Nov 7, 2024
@Dominaezzz
Copy link
Collaborator

PR was merged

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants