Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over existing peripheral drivers from esp32-hal #65

Closed
12 of 16 tasks
jessebraham opened this issue May 27, 2022 · 3 comments
Closed
12 of 16 tasks

Port over existing peripheral drivers from esp32-hal #65

jessebraham opened this issue May 27, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@jessebraham
Copy link
Member

jessebraham commented May 27, 2022

There are a number of peripheral drivers already implemented in the esp32-hal repository. Since this crate has been published, we aren't really able to release a new version until we've roughly reached feature-parity with the previous implementation. Because of this, we should begin working on porting this drivers.

These can either just be dumped in the esp32-hal package for now, making the required changes just to get things building, or can be re-written to be compatible across all supported chips. While the latter method is preferable, the prior is likely the more realistic path forward.

The existing drivers are:

@jessebraham jessebraham added enhancement help wanted Extra attention is needed labels May 27, 2022
@jessebraham jessebraham moved this to Todo in esp-rs May 27, 2022
@jessebraham jessebraham pinned this issue May 30, 2022
@bjoernQ
Copy link
Contributor

bjoernQ commented Jun 1, 2022

I think dprint shouldn't get ported since we have esp-println for that.

For clock control we also already have issue #44

I'm not sure if this really should be a hard requirement for a potential release. Someone using the deprecated HAL can just pin the version and even more important even if we have all of those the new HAL isn't a drop-in replacement since many things are just different (for good reasons).

But certainly, it would be a good thing to cover all of those

@bjoernQ
Copy link
Contributor

bjoernQ commented Jun 15, 2022

We have support for timer - what we should do however is handling it similar to SYSTIMER and split each timer to make use of the three alarms. But I'd say that is a "nice-to-have" enhancement

I'm not sure about that mem feature - while it's easy to copy over we should actually benchmark that it is really an improvement (I doubt it is - see https://github.com/rust-lang/compiler-builtins/blob/master/src/mem/impls.rs )

@jessebraham
Copy link
Member Author

I'm going to close this. Other than LEDC (which is in progress and hopefully will be merged in the coming weeks) there's not really anything left worth worrying about right now, I don't think.

Repository owner moved this from Todo to Done in esp-rs Jul 20, 2022
@jessebraham jessebraham unpinned this issue Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants