Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Digest traits for SHA #941

Closed
Natureshadow opened this issue Nov 14, 2023 · 1 comment · Fixed by #1908
Closed

Implement Digest traits for SHA #941

Natureshadow opened this issue Nov 14, 2023 · 1 comment · Fixed by #1908
Labels
help wanted Extra attention is needed peripheral:sha SHA peripheral

Comments

@Natureshadow
Copy link

In order to use the hardware-accelerated SHA on ESP32 with external code that accepts implementations of the digest traits, it would be helpful to implement those on the Sha struct.

The implementation should probably be behind a digest feature flag in order to avoid the dependency if not needed.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 15, 2023

+1 - we should implement the crypto traits for all crypto-accelerators: https://github.com/RustCrypto/traits

but we will need to do what is worked on in #866 for them first

@jessebraham jessebraham added the peripheral:sha SHA peripheral label Mar 13, 2024
@jessebraham jessebraham added the help wanted Extra attention is needed label Jul 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed peripheral:sha SHA peripheral
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants