Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches are not being applied to esp32-s3 SVD file #276

Closed
Joebeazelman opened this issue Aug 29, 2024 · 2 comments
Closed

Patches are not being applied to esp32-s3 SVD file #276

Joebeazelman opened this issue Aug 29, 2024 · 2 comments

Comments

@Joebeazelman
Copy link

After executing the following patch command:

cargo xtask patch esp32s3

The generated esp32s3 still contains %s. I might be wrong, but I expected it to produce an XML file without the %s.

@jessebraham
Copy link
Member

To the very best of my knowledge the patches are working as intended. The %s placeholder is part of the CMSIS SVD specification and is expected to be present in the SVD for repeating elements, this is handled by svd2rust without issue.

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Aug 30, 2024
@Joebeazelman
Copy link
Author

Can SVD2Rust generate precompiled XML with the placeholders substituted? If not, do you know of such a tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants