Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Why does esp-template use v0.2.7 of embedded-hal instead of expected v1.0.0? #155

Closed
henryshunt opened this issue Mar 27, 2024 · 2 comments

Comments

@henryshunt
Copy link

henryshunt commented Mar 27, 2024

If I create a new project for the ESP32-S3 using cargo generate esp-rs/esp-template and run cargo tree, I see dependencies on v0.2.7 of embedded-hal by esp-hal v0.16.1 and esp-synopsys-usb-otg v0.4.0. I had expected there to be only dependencies on v1.0.0 of embedded-hal given that from reading some of the release notes it appears that v1.0.0 is properly supported (and thus I assume it is supposed to be the default). Additionally, esp-hal's Cargo.toml file specifies that it should use v1.0.0 (except for the embedded-hal-02 case to support the old version of course).

I'm trying to use v1.0.0 of embedded-hal in an S3 project I'm working on, but this is causing a compilation error when I work with GPIO in a certain way. I believe this is caused by this version mismatch.

I can post the error when I get home if necessary, but I'm primarily just trying to understand where the old version of embedded-hal is coming from given that from what I can tell, it should be using v1.0.0.

@jessebraham jessebraham transferred this issue from esp-rs/esp-hal Mar 27, 2024
@SergioGasquez
Copy link
Member

Some drivers are still using embedded-hal 0.2.7, see esp-rs/esp-hal#1317. Also note that some drivers are already merged (esp-rs/esp-hal#1317 (comment)) are not yet released.

@henryshunt
Copy link
Author

Ah, well that explains things then. I was under the mistaken impression that the v1.0.0 support was already completed. Thanks!

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants