Skip to content

Commit 559a286

Browse files
igrrdevyte
authored andcommitted
Minor fixes for #4999 (#5003)
* ci: work around tagging issue in Travis CI deployment When `draft: true` is set, incorrect commit/tag information is sent to Github. Override tag/target fields for correct behavior. Ref. https://github.com/travis-ci/travis-ci/issues/9852 * doc: clarify some points in the release process
1 parent f776454 commit 559a286

File tree

2 files changed

+26
-10
lines changed

2 files changed

+26
-10
lines changed

.travis.yml

+2
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ deploy:
5050
api_key:
5151
secure: A4FBmqyhlzy33oPeZVolg2Q/A3ZcJ3WnRQqQJ3NAPy+qGM5xcboOYtwcLL9vKaHZGfUB7lUP9QVZFGou1Wrmo9DnPvAoe3+XvCaDRGzVMxeIpu7UStbBD4Knbh98tlbMvZCXYRlT4VcusI9bMLK6UWw4sMdPislBh2FEfglTiag=
5252
file_glob: true
53+
tag_name: $TRAVIS_TAG
54+
target_commitish: $TRAVIS_COMMIT
5355
file:
5456
- package/versions/$TRAVIS_TAG/esp8266-$TRAVIS_TAG.zip
5557
- package/versions/$TRAVIS_TAG/package_esp8266com_index.json

package/README.md

+24-10
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ The purpose of the release process is to generate the following outputs from the
1111

1212
* Github Release for esp8266/Arduino project. This is used to host the boards manager package mentioned above, and also contains the release notes.
1313

14-
Here is an overview of the release process.
14+
Here is an overview of the release process. See the section below for detailed instructions.
1515

1616
1. Release process starts when a maintainer pushes a tag into the repository.
1717

@@ -51,29 +51,43 @@ Here is an overview of the release process.
5151

5252
* Not all commit descriptions which come from `git log` will explain changes well. Reword items as necessary, with the goal that a general user of this project should be able to understand what the change is related to. Preserve references to PRs or issues (`#XXXX`).
5353

54-
* Don't include fixes for issues which have been introduced since last release.
54+
* Don't include fixes for regressions which have been introduced since last release.
5555

5656
* Aggregate minor fixes (e.g. typos, small documentation changes) in a few items. Focus on preparing a good overview of the release for the users, rather than mentioning every change.
5757

5858
* When done, put release notes into a private Gist and send the link to other maintainers for review.
5959

60-
2. Tag the latest commit. In this project, tags have form `X.Y.Z`, e.g. `2.4.0`, or `X.Y.Z-rcN` for release versions. Notice that there's no `v`at the beginning of the tag. Tags must be annotated, not lightweight tags. To create a tag, use git command (assuming that the master branch is checked out):
60+
2. Create a commit on the master branch, making the following changes:
61+
62+
* Set version in platform.txt to the version about to be released. E.g. change from `2.4.0-dev` to `2.4.0`
63+
64+
* In main README.md, in "Latest release" section, change version number in the readthedocs link to the version which is about to be created.
65+
66+
* Commit message should be `Release X.Y.Z`
67+
68+
3. Tag the commit created in step 2. In this project, tags have form `X.Y.Z`, e.g. `2.4.0`, or `X.Y.Z-rcN` for release versions. Notice that there's no `v`at the beginning of the tag. Tags must be annotated, not lightweight tags. To create a tag, use git command (assuming that the master branch is checked out):
6169

6270
```
6371
git tag -a -m "Release 2.4.0" 2.4.0
6472
```
65-
66-
Push the tag to esp8266/Arduino Github repository.
6773

74+
4. Push the commit created in step 2 and the tag created in step 3 to esp8266/Arduino Github repository:
75+
76+
```
77+
git push origin --follow-tags master
78+
```
79+
80+
5. Wait for Travis CI build for the tag to pass. Check that the new (draft) release has been created. Check that the boards manager package .zip file has been successfully uploaded as a release artifact.
6881

69-
3. Wait for Travis CI build for the tag to pass. Check that the new (draft) release has been created. Check that the boards manager package .zip file has been successfully uploaded as a release artifact.
82+
6. Check that the package index downloaded from http://arduino.esp8266.com/stable/package_esp8266_index.json contains an entry for the new version (it may not be the first one).
7083

71-
4. Check that the package index downloaded from http://arduino.esp8266.com/stable/package_esp8266_index.json contains an entry for the new version (it may not be the first one).
84+
7. Navigate to release list in Github, press "Edit" button to edit release description, paste release notes. Remove "draft" status of the release and publish it.
7285

73-
5. Navigate to release list in Github, press "Edit" button to edit release description, paste release notes. Remove "draft" status of the release and publish it.
86+
8. In the issue tracker, remove "staged-for-release" label for all issues which have it, and close them. Close the milestone associated with the released version.
7487

75-
6. In the issue tracker, remove "staged-for-release" label for all issues which have it, and close them. Close the milestone associated with the released version.
88+
9. Create a commit to the master branch, updating:
7689

77-
7. Make a commit to master branch, updating the version in platform.txt file. This should correspond to the version of the *next* milestone.
90+
* The version in platform.txt file. This should correspond to the version of the *next* milestone, plus `-dev` suffix. E.g. `2.5.0-dev`.
7891

92+
* In main README.md, in "Contributing" section, update the "easy issues" link to point to the next milestone.
7993

0 commit comments

Comments
 (0)