Add option to give ArduinoOTA a hashed value of the password

hashed password can be safely stored on flash

Author: Me No Dev

libraries/ArduinoOTA/ArduinoOTA.cpp

@@ -29,6 +29,7 @@ extern "C" {
 
 ArduinoOTAClass::ArduinoOTAClass()
 : _port(0)
+, _pass_is_hash(false)
 , _udp_ota(0)
 , _initialized(false)
 , _state(OTA_IDLE)
@@ -81,9 +82,10 @@ String ArduinoOTAClass::getHostname() {
   return _hostname;
 }
 
-void ArduinoOTAClass::setPassword(const char * password) {
+void ArduinoOTAClass::setPassword(const char * password, bool isHash) {
   if (!_initialized && !_password.length() && password) {
     _password = password;
+    _pass_is_hash = isHash;
   }
 }
 
@@ -206,11 +208,14 @@ void ArduinoOTAClass::_onRx(){
       return;
     }
 
-    MD5Builder _passmd5;
-    _passmd5.begin();
-    _passmd5.add(_password);
-    _passmd5.calculate();
-    String passmd5 = _passmd5.toString();
+    String passmd5 = _password;
+    if(!_pass_is_hash){
+      MD5Builder _passmd5;
+      _passmd5.begin();
+      _passmd5.add(_password);
+      _passmd5.calculate();
+      passmd5 = _passmd5.toString();
+    }
 
     String challenge = passmd5 + ":" + String(_nonce) + ":" + cnonce;
     MD5Builder _challengemd5;

libraries/ArduinoOTA/ArduinoOTA.h

@@ -33,7 +33,7 @@ class ArduinoOTAClass
     void setPort(uint16_t port);
     void setHostname(const char *hostname);
     String getHostname();
-    void setPassword(const char *password);
+    void setPassword(const char *password, bool isHash=false);
     void onStart(THandlerFunction fn);
     void onEnd(THandlerFunction fn);
     void onError(THandlerFunction_Error fn);
@@ -44,6 +44,7 @@ class ArduinoOTAClass
 
   private:
     int _port;
+    bool _pass_is_hash;
     String _password;
     String _hostname;
     String _nonce;

libraries/ArduinoOTA/examples/BasicOTA/BasicOTA.ino

@@ -24,7 +24,11 @@ void setup() {
   // ArduinoOTA.setHostname("myesp8266");
 
   // No authentication by default
-  // ArduinoOTA.setPassword((const char *)"123");
+  // ArduinoOTA.setPassword("admin");
+
+  // Password can be set with it's md5 value as well
+  // MD5(admin) = 21232f297a57a5a743894a0e4a801fc3
+  // ArduinoOTA.setPassword("21232f297a57a5a743894a0e4a801fc3", true);
 
   ArduinoOTA.onStart([]() {
     String type;