Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWM-locked support not properly working after "PWM/Phase"-locked merge #7977

Closed
dok-net opened this issue Apr 12, 2021 · 0 comments · Fixed by #7978
Closed

PWM-locked support not properly working after "PWM/Phase"-locked merge #7977

dok-net opened this issue Apr 12, 2021 · 0 comments · Fixed by #7978

Comments

@dok-net
Copy link
Contributor

dok-net commented Apr 12, 2021

There's a serious functionality, probably also performance, issue caused by the runtime selection patch that did away with the preprocessor #define based switch between "PWM locked" and "phase locked" waveform modes.

See libraries/Servo/src/Servo.cpp, in Servo::attach, Servo::detach, Servo::writeMicroseconds the conditional compilation cannot occur.
@dok-net dok-net mentioned this issue Apr 12, 2021
Merged
@dok-net dok-net changed the title PWM locked support not properly continued by merge PWM-locked support not properly workiing after "PWM/Phase"-locked merge Apr 16, 2021
@dok-net dok-net changed the title PWM-locked support not properly workiing after "PWM/Phase"-locked merge PWM-locked support not properly working after "PWM/Phase"-locked merge Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve "PWM-locked" / "phase-locked" waveform merge leftover in Servo lib dok-net/arduino-esp8266
1 participant
@dok-net