Update upload.py #6781
Closed
Update upload.py #6781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about that ^ |
|
Only eating the '--end' is not working because ['write_flash', '0x0'] is appended and the binary is moved to the end. Also if another unknown plugin should use upload.py with two '--end' in one command esptool would not execute twice or (n-) times. As I'm a python beginner I did not know nesting if..else statements is a bad thing. What could happen while using the outer if-else (other than an ugly diff)? |
|
Did not see your solution before. Thanks to your solution I learned about the if..elif statement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May another solution to:
#6777