Fix missing typedef causing multiple definition linker errors (GIT8266O-886) #1308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The enum declaration for
esp_image_spi_freq_t
incomponents/bootloader_support/include/esp_image_format.h
line 40 is missing thetypedef
keyword.This causes the compiler to create a global variable instead of a type definition, resulting in "multiple definition" linker errors when building with stricter toolchains (e.g., PlatformIO's xtensa-lx106-elf gcc 10.3.0).
Error Example
Solution
Add the missing
typedef
keyword to make it consistent with the enum declaration above it (lines 34-37).Before
After
Testing