Warnings fixes

Author: me-no-dev

Diff for: .gitignore

@@ -40,3 +40,4 @@ _build/
 debug.cfg
 debug.svd
 debug_custom.json
+libraries/Insights/examples/*/*.ino.zip

Diff for: cores/esp32/HWCDC.cpp

@@ -22,7 +22,9 @@
 #include "freertos/ringbuf.h"
 #include "esp_intr_alloc.h"
 #include "soc/periph_defs.h"
+#pragma GCC diagnostic ignored "-Wvolatile"
 #include "hal/usb_serial_jtag_ll.h"
+#pragma GCC diagnostic warning "-Wvolatile"
 #include "rom/ets_sys.h"
 
 ESP_EVENT_DEFINE_BASE(ARDUINO_HW_CDC_EVENTS);

Diff for: cores/esp32/esp32-hal-gpio.c

@@ -98,7 +98,7 @@ extern void ARDUINO_ISR_ATTR __pinMode(uint8_t pin, uint8_t mode)
     }
 #endif
 
-    if (!GPIO_IS_VALID_GPIO(pin)) {
+    if (pin >= SOC_GPIO_PIN_COUNT) {
         log_e("Invalid pin selected");
         return;
     }

Diff for: cores/esp32/esp32-hal-spi.c

@@ -1515,11 +1515,11 @@ uint32_t spiFrequencyToClockDiv(uint32_t freq)
 
     uint8_t calN = 1;
     spiClk_t bestReg = { 0 };
-    int32_t bestFreq = 0;
+    uint32_t bestFreq = 0;
 
     while(calN <= 0x3F) {
         spiClk_t reg = { 0 };
-        int32_t calFreq;
+        uint32_t calFreq;
         int32_t calPre;
         int8_t calPreVari = -2;
 
@@ -1541,11 +1541,11 @@ uint32_t spiFrequencyToClockDiv(uint32_t freq)
             }
             reg.clkcnt_l = ((reg.clkcnt_n + 1) / 2);
             calFreq = ClkRegToFreq(&reg);
-            if(calFreq == (int32_t) freq) {
+            if(calFreq == freq) {
                 memcpy(&bestReg, &reg, sizeof(bestReg));
                 break;
-            } else if(calFreq < (int32_t) freq) {
-                if(abs(freq - calFreq) < abs(freq - bestFreq)) {
+            } else if(calFreq < freq) {
+                if((freq - calFreq) < (freq - bestFreq)) {
                     bestFreq = calFreq;
                     memcpy(&bestReg, &reg, sizeof(bestReg));
                 }

Diff for: cores/esp32/esp32-hal-touch.c

@@ -91,7 +91,12 @@ static void __touchSetCycles(uint16_t measure, uint16_t sleep)
 {
     __touchSleepCycles = sleep;
     __touchMeasureCycles = measure;
-    touch_pad_set_meas_time(sleep, measure);
+#if SOC_TOUCH_VERSION_1                         // ESP32
+    touch_pad_set_measurement_clock_cycles(measure);
+#elif SOC_TOUCH_VERSION_2                         // ESP32S2, ESP32S3
+    touch_pad_set_charge_discharge_times(measure);
+#endif
+    touch_pad_set_measurement_interval(sleep);
 }
 
 
@@ -112,7 +117,8 @@ static void __touchInit()
     }
     // the next two lines will drive the touch reading values -- both will return ESP_OK
     touch_pad_set_voltage(TOUCH_HVOLT_2V7, TOUCH_LVOLT_0V5, TOUCH_HVOLT_ATTEN_0V); 
-    touch_pad_set_meas_time(__touchMeasureCycles, __touchSleepCycles);
+    touch_pad_set_measurement_clock_cycles(__touchMeasureCycles);
+    touch_pad_set_measurement_interval(__touchSleepCycles);
     // Touch Sensor Timer initiated
     touch_pad_set_fsm_mode(TOUCH_FSM_MODE_TIMER);   // returns ESP_OK
     err = touch_pad_filter_start(10);
@@ -131,7 +137,8 @@ static void __touchInit()
         goto err;
     }
     // the next lines will drive the touch reading values -- all os them return ESP_OK
-    touch_pad_set_meas_time(__touchSleepCycles, __touchMeasureCycles);
+    touch_pad_set_charge_discharge_times(__touchMeasureCycles);
+    touch_pad_set_measurement_interval(__touchSleepCycles);
     touch_pad_set_voltage(TOUCH_PAD_HIGH_VOLTAGE_THRESHOLD, TOUCH_PAD_LOW_VOLTAGE_THRESHOLD, TOUCH_PAD_ATTEN_VOLTAGE_THRESHOLD);
     touch_pad_set_idle_channel_connect(TOUCH_PAD_IDLE_CH_CONNECT_DEFAULT);
     touch_pad_denoise_t denoise = {

Diff for: cores/esp32/wiring_pulse.c

@@ -17,11 +17,11 @@
 //#include <limits.h>
 #include "wiring_private.h"
 #include "pins_arduino.h"
-#include <hal/cpu_hal.h>
+#include "esp_cpu.h"
 
 #define WAIT_FOR_PIN_STATE(state) \
     while (digitalRead(pin) != (state)) { \
-        if (cpu_hal_get_cycle_count() - start_cycle_count > timeout_cycles) { \
+        if (esp_cpu_get_cycle_count() - start_cycle_count > timeout_cycles) { \
             return 0; \
         } \
     }
@@ -34,12 +34,12 @@ unsigned long pulseIn(uint8_t pin, uint8_t state, unsigned long timeout)
         timeout = max_timeout_us;
     }
     const uint32_t timeout_cycles = microsecondsToClockCycles(timeout);
-    const uint32_t start_cycle_count = cpu_hal_get_cycle_count();
+    const uint32_t start_cycle_count = esp_cpu_get_cycle_count();
     WAIT_FOR_PIN_STATE(!state);
     WAIT_FOR_PIN_STATE(state);
-    const uint32_t pulse_start_cycle_count = cpu_hal_get_cycle_count();
+    const uint32_t pulse_start_cycle_count = esp_cpu_get_cycle_count();
     WAIT_FOR_PIN_STATE(!state);
-    return clockCyclesToMicroseconds(cpu_hal_get_cycle_count() - pulse_start_cycle_count);
+    return clockCyclesToMicroseconds(esp_cpu_get_cycle_count() - pulse_start_cycle_count);
 }
 
 unsigned long pulseInLong(uint8_t pin, uint8_t state, unsigned long timeout)

Diff for: libraries/BLE/examples/BLE5_multi_advertising/BLE5_multi_advertising.ino

@@ -15,7 +15,10 @@ esp_ble_gap_ext_adv_params_t ext_adv_params_1M = {
     .interval_max = 0x30,
     .channel_map = ADV_CHNL_ALL,
     .own_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr = {0,0,0,0,0,0},
     .filter_policy = ADV_FILTER_ALLOW_SCAN_ANY_CON_ANY,
+    .tx_power = EXT_ADV_TX_PWR_NO_PREFERENCE,
     .primary_phy = ESP_BLE_GAP_PHY_CODED,
     .max_skip = 0,
     .secondary_phy = ESP_BLE_GAP_PHY_1M,
@@ -29,7 +32,10 @@ esp_ble_gap_ext_adv_params_t ext_adv_params_2M = {
     .interval_max = 0x40,
     .channel_map = ADV_CHNL_ALL,
     .own_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr = {0,0,0,0,0,0},
     .filter_policy = ADV_FILTER_ALLOW_SCAN_ANY_CON_ANY,
+    .tx_power = EXT_ADV_TX_PWR_NO_PREFERENCE,
     .primary_phy = ESP_BLE_GAP_PHY_1M,
     .max_skip = 0,
     .secondary_phy = ESP_BLE_GAP_PHY_2M,
@@ -43,7 +49,10 @@ esp_ble_gap_ext_adv_params_t legacy_adv_params = {
     .interval_max = 0x45,
     .channel_map = ADV_CHNL_ALL,
     .own_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr = {0,0,0,0,0,0},
     .filter_policy = ADV_FILTER_ALLOW_SCAN_ANY_CON_ANY,
+    .tx_power = EXT_ADV_TX_PWR_NO_PREFERENCE,
     .primary_phy = ESP_BLE_GAP_PHY_1M,
     .max_skip = 0,
     .secondary_phy = ESP_BLE_GAP_PHY_1M,
@@ -57,7 +66,10 @@ esp_ble_gap_ext_adv_params_t ext_adv_params_coded = {
     .interval_max = 0x50,
     .channel_map = ADV_CHNL_ALL,
     .own_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr = {0,0,0,0,0,0},
     .filter_policy = ADV_FILTER_ALLOW_SCAN_ANY_CON_ANY,
+    .tx_power = EXT_ADV_TX_PWR_NO_PREFERENCE,
     .primary_phy = ESP_BLE_GAP_PHY_1M,
     .max_skip = 0,
     .secondary_phy = ESP_BLE_GAP_PHY_CODED,

Diff for: libraries/BLE/examples/BLE5_periodic_advertising/BLE5_periodic_advertising.ino

@@ -15,7 +15,10 @@ esp_ble_gap_ext_adv_params_t ext_adv_params_2M = {
     .interval_max = 0x40,
     .channel_map = ADV_CHNL_ALL,
     .own_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr_type = BLE_ADDR_TYPE_RANDOM,
+    .peer_addr = {0,0,0,0,0,0},
     .filter_policy = ADV_FILTER_ALLOW_SCAN_ANY_CON_ANY,
+    .tx_power = EXT_ADV_TX_PWR_NO_PREFERENCE,
     .primary_phy = ESP_BLE_GAP_PHY_1M,
     .max_skip = 0,
     .secondary_phy = ESP_BLE_GAP_PHY_2M,

Diff for: libraries/BLE/examples/BLE5_periodic_sync/BLE5_periodic_sync.ino

@@ -21,6 +21,7 @@ static esp_ble_gap_periodic_adv_sync_params_t periodic_adv_sync_params = {
     .filter_policy = 0,
     .sid = 0,
     .addr_type = BLE_ADDR_TYPE_RANDOM,
+    .addr = {0,0,0,0,0,0},
     .skip = 10,
     .sync_timeout = 1000, // timeout: 1000 * 10ms
 };

Diff for: libraries/BluetoothSerial/src/BluetoothSerial.cpp

@@ -673,7 +673,9 @@ static bool _init_bt(const char *deviceName)
         return false;
     }
 
-    if (esp_spp_init(ESP_SPP_MODE_CB) != ESP_OK){
+    esp_spp_cfg_t cfg = BT_SPP_DEFAULT_CONFIG();
+    cfg.mode = ESP_SPP_MODE_CB;
+    if (esp_spp_enhanced_init(&cfg) != ESP_OK){
         log_e("spp init failed");
         return false;
     }

Diff for: libraries/ESP32/examples/Camera/CameraWebServer/CameraWebServer.ino

@@ -59,8 +59,8 @@ void setup() {
   config.pin_pclk = PCLK_GPIO_NUM;
   config.pin_vsync = VSYNC_GPIO_NUM;
   config.pin_href = HREF_GPIO_NUM;
-  config.pin_sscb_sda = SIOD_GPIO_NUM;
-  config.pin_sscb_scl = SIOC_GPIO_NUM;
+  config.pin_sccb_sda = SIOD_GPIO_NUM;
+  config.pin_sccb_scl = SIOC_GPIO_NUM;
   config.pin_pwdn = PWDN_GPIO_NUM;
   config.pin_reset = RESET_GPIO_NUM;
   config.xclk_freq_hz = 20000000;

Diff for: libraries/ESP32/examples/Camera/CameraWebServer/app_httpd.cpp

@@ -50,10 +50,12 @@
 
 #if CONFIG_ESP_FACE_RECOGNITION_ENABLED
 #pragma GCC diagnostic ignored "-Wformat"
+#pragma GCC diagnostic ignored "-Wstrict-aliasing"
 #include "face_recognition_tool.hpp"
 #include "face_recognition_112_v1_s16.hpp"
 #include "face_recognition_112_v1_s8.hpp"
 #pragma GCC diagnostic error "-Wformat"
+#pragma GCC diagnostic warning "-Wstrict-aliasing"
 
 #define QUANT_TYPE 0 //if set to 1 => very large firmware, very slow, reboots when streaming...
 

Diff for: libraries/ESP32/examples/FreeRTOS/FreeRTOS.ino

@@ -1,3 +1,6 @@
+#ifdef ARDUINO_RUNNING_CORE
+#undef ARDUINO_RUNNING_CORE
+#endif
 #if CONFIG_FREERTOS_UNICORE
 #define ARDUINO_RUNNING_CORE 0
 #else

Diff for: libraries/ESP32/examples/GPIO/FunctionalInterrupt/FunctionalInterrupt.ino

@@ -16,7 +16,7 @@ public:
 	}
 
 	void ARDUINO_ISR_ATTR isr() {
-		numberKeyPresses += 1;
+		numberKeyPresses = numberKeyPresses + 1;
 		pressed = true;
 	}
 

Diff for: libraries/ESP32/examples/I2S/HiFreq_ADC/HiFreq_ADC.ino

@@ -51,7 +51,9 @@ void i2sInit(){
     .dma_buf_len = I2S_DMA_BUF_LEN,
     .use_apll = false,
     .tx_desc_auto_clear = false,
-    .fixed_mclk = 0
+    .fixed_mclk = 0,
+    .mclk_multiple = esp_i2s::I2S_MCLK_MULTIPLE_128,
+    .bits_per_chan = esp_i2s::I2S_BITS_PER_CHAN_DEFAULT
   };
   Serial.printf("Attempting to setup I2S ADC with sampling frequency %d Hz\n", I2S_SAMPLE_RATE);
   if(ESP_OK != i2s_driver_install(I2S_NUM_0, &i2s_config, 0, NULL)){

Diff for: libraries/ESP32/examples/Serial/OnReceiveError_BREAK_Demo/OnReceiveError_BREAK_Demo.ino

@@ -84,7 +84,7 @@ void onReceiveErrorFunction(hardwareSerial_error_t err) {
 void onReceiveFunction() {
   // This is a callback function that will be activated on UART RX events
   size_t available = Serial1.available();
-  received_bytes += available;
+  received_bytes = received_bytes + available;
   Serial.printf("onReceive Callback:: There are %d bytes available: {", available);
   while (available --) {
     Serial.print((char)Serial1.read());

Diff for: libraries/ESP32/examples/Serial/OnReceive_Demo/OnReceive_Demo.ino

@@ -60,7 +60,7 @@ volatile size_t sent_bytes = 0, received_bytes = 0;
 void onReceiveFunction(void) {
   // This is a callback function that will be activated on UART RX events
   size_t available = Serial1.available();
-  received_bytes += available;
+  received_bytes = received_bytes + available;
   Serial.printf("onReceive Callback:: There are %d bytes available: ", available);
   while (available --) {
     Serial.print((char)Serial1.read());

Diff for: libraries/ESP32/examples/TWAI/TWAIreceive/TWAIreceive.ino

@@ -24,6 +24,7 @@
   created 05-11-2022 by Stephan Martin (designer2k2)
 */
 
+#pragma GCC diagnostic ignored "-Wmissing-field-initializers"
 #include "driver/twai.h"
 
 // Pins used to connect to CAN bus transceiver:

Diff for: libraries/ESP32/examples/Timer/RepeatTimer/RepeatTimer.ino

@@ -21,7 +21,7 @@ volatile uint32_t lastIsrAt = 0;
 void ARDUINO_ISR_ATTR onTimer(){
   // Increment the counter and set the time of ISR
   portENTER_CRITICAL_ISR(&timerMux);
-  isrCounter++;
+  isrCounter = isrCounter + 1;
   lastIsrAt = millis();
   portEXIT_CRITICAL_ISR(&timerMux);
   // Give a semaphore that we can check in the loop

Diff for: libraries/FFat/src/FFat.cpp

@@ -53,12 +53,13 @@ bool F_Fat::begin(bool formatOnFail, const char * basePath, uint8_t maxOpenFiles
     esp_vfs_fat_mount_config_t conf = {
       .format_if_mount_failed = formatOnFail,
       .max_files = maxOpenFiles,
-      .allocation_unit_size = CONFIG_WL_SECTOR_SIZE
+      .allocation_unit_size = CONFIG_WL_SECTOR_SIZE,
+      .disk_status_check_enable = false
     };
-    esp_err_t err = esp_vfs_fat_spiflash_mount(basePath, partitionLabel, &conf, &_wl_handle);
+    esp_err_t err = esp_vfs_fat_spiflash_mount_rw_wl(basePath, partitionLabel, &conf, &_wl_handle);
     if(err){
         log_e("Mounting FFat partition failed! Error: %d", err);
-        esp_vfs_fat_spiflash_unmount(basePath, _wl_handle);
+        esp_vfs_fat_spiflash_unmount_rw_wl(basePath, _wl_handle);
         _wl_handle = WL_INVALID_HANDLE;
         return false;
     }
@@ -69,7 +70,7 @@ bool F_Fat::begin(bool formatOnFail, const char * basePath, uint8_t maxOpenFiles
 void F_Fat::end()
 {
     if(_wl_handle != WL_INVALID_HANDLE){
-        esp_err_t err = esp_vfs_fat_spiflash_unmount(_impl->mountpoint(), _wl_handle);
+        esp_err_t err = esp_vfs_fat_spiflash_unmount_rw_wl(_impl->mountpoint(), _wl_handle);
         if(err){
             log_e("Unmounting FFat partition failed! Error: %d", err);
             return;
@@ -109,13 +110,14 @@ bool F_Fat::format(bool full_wipe, char* partitionLabel)
     esp_vfs_fat_mount_config_t conf = {
       .format_if_mount_failed = true,
       .max_files = 1,
-      .allocation_unit_size = CONFIG_WL_SECTOR_SIZE
+      .allocation_unit_size = CONFIG_WL_SECTOR_SIZE,
+      .disk_status_check_enable = false
     };
-    result = esp_vfs_fat_spiflash_mount("/format_ffat", partitionLabel, &conf, &temp_handle);
-    esp_vfs_fat_spiflash_unmount("/format_ffat", temp_handle);
+    result = esp_vfs_fat_spiflash_mount_rw_wl("/format_ffat", partitionLabel, &conf, &temp_handle);
+    esp_vfs_fat_spiflash_unmount_rw_wl("/format_ffat", temp_handle);
     if (result != ESP_OK){
         res = false;
-        log_w("esp_vfs_fat_spiflash_mount failed!");
+        log_w("esp_vfs_fat_spiflash_mount_rw_wl failed!");
     }
     return res;
 }

Diff for: libraries/I2S/src/I2S.cpp

@@ -144,7 +144,20 @@ int I2SClass::_installDriver(){
     .intr_alloc_flags = ESP_INTR_FLAG_LEVEL2,
     .dma_buf_count = _I2S_DMA_BUFFER_COUNT,
     .dma_buf_len = _i2s_dma_buffer_size,
-    .use_apll = false
+    .use_apll = false,
+    #warning The following values are new and need to be checked
+    .tx_desc_auto_clear = true,
+    .fixed_mclk = 0,
+    .mclk_multiple = esp_i2s::I2S_MCLK_MULTIPLE_128,
+    .bits_per_chan = esp_i2s::I2S_BITS_PER_CHAN_DEFAULT
+#if SOC_I2S_SUPPORTS_TDM
+    ,.chan_mask = esp_i2s::I2S_CHANNEL_STEREO,
+    .total_chan = 2,
+    .left_align = false,
+    .big_edin = false,
+    .bit_order_msb = false,
+    .skip_msk = false
+#endif // SOC_I2S_SUPPORTS_TDM
   };
 
   if(_driveClock == false){
@@ -317,6 +330,7 @@ int I2SClass::begin(int mode, int sampleRate, int bitsPerSample, bool driveClock
 int I2SClass::_applyPinSetting(){
   if(_driverInstalled){
     esp_i2s::i2s_pin_config_t pin_config = {
+      .mck_io_num = I2S_PIN_NO_CHANGE,
       .bck_io_num = _sckPin,
       .ws_io_num = _fsPin,
       .data_out_num = I2S_PIN_NO_CHANGE,

Diff for: libraries/RainMaker/src/RMaker.cpp

@@ -139,6 +139,7 @@ esp_err_t RMakerClass::enableOTA(ota_type_t type, const char *cert)
         .ota_cb = NULL,
         .ota_diag = NULL,
         .server_cert = cert,
+        .priv = NULL
     };
     err = esp_rmaker_ota_enable(&ota_config, type);
     if(err != ESP_OK) {

Diff for: libraries/SD_MMC/src/SD_MMC.cpp

@@ -123,7 +123,8 @@ bool SDMMCFS::begin(const char * mountpoint, bool mode1bit, bool format_if_mount
     esp_vfs_fat_sdmmc_mount_config_t mount_config = {
         .format_if_mount_failed = format_if_mount_failed,
         .max_files = maxOpenFiles,
-        .allocation_unit_size = 0
+        .allocation_unit_size = 0,
+        .disk_status_check_enable = false
     };
 
     esp_err_t ret = esp_vfs_fat_sdmmc_mount(mountpoint, &host, &slot_config, &mount_config, &_card);

Diff for: libraries/WebServer/examples/SDWebServer/SDWebServer.ino

@@ -214,7 +214,6 @@ void printDirectory() {
   dir.rewindDirectory();
   server.setContentLength(CONTENT_LENGTH_UNKNOWN);
   server.send(200, "text/json", "");
-  WiFiClient client = server.client();
 
   server.sendContent("[");
   for (int cnt = 0; true; ++cnt) {

Diff for: libraries/WebServer/src/WebServer.h

@@ -95,7 +95,7 @@ class WebServer
 
   String uri() { return _currentUri; }
   HTTPMethod method() { return _currentMethod; }
-  virtual WiFiClient client() { return _currentClient; }
+  virtual WiFiClient & client() { return _currentClient; }
   HTTPUpload& upload() { return *_currentUpload; }
 
   String pathArg(unsigned int i); // get request path argument by number

Diff for: libraries/WiFi/examples/WiFiAccessPoint/WiFiAccessPoint.ino

@@ -15,7 +15,9 @@
 #include <WiFiClient.h>
 #include <WiFiAP.h>
 
+#ifndef LED_BUILTIN
 #define LED_BUILTIN 2   // Set the GPIO pin where you connected your test LED or comment this line out if your dev board has a built-in LED
+#endif
 
 // Set these to your desired credentials.
 const char *ssid = "yourAP";