Skip to content

fix(board): Update PSRAM configuration for RAK3112 to fix PSRAM error #11552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2025
Merged

fix(board): Update PSRAM configuration for RAK3112 to fix PSRAM error #11552

merged 4 commits into from
Jul 7, 2025
+17 −2

Conversation

@DanielCao0
Copy link
Contributor

@DanielCao0 DanielCao0 commented Jul 4, 2025 •
edited
Loading

fix : quad_psram: psram id read error: 0x00ffffff, psram chip not found or not supported, or wrong psram line mode arduino

Configuration updates for rakwireless_rak3112:

  • Added a new psram_type property with the value opi to specify the type of PSRAM used.
  • Introduced a memory_type property that dynamically combines build.boot and build.psram_type for better memory type management.
  • Updated the menu.PSRAM.enabled description to "OPI PSRAM" for clarity.
  • Add wisblock pin define

@DanielCao0 DanielCao0 requested a review from P-R-O-C-H-Y as a code owner July 4, 2025 02:59
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello DanielCao0, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b86c681

me-no-dev
me-no-dev reviewed Jul 4, 2025
View reviewed changes
me-no-dev
me-no-dev reviewed Jul 4, 2025
View reviewed changes
@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Jul 7, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jul 7, 2025
@me-no-dev me-no-dev merged commit d3c5a82 into espressif:master Jul 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DanielCao0 @me-no-dev @P-R-O-C-H-Y @danielRAKwireless