-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appending questions to MDNS responses breaks Avahi-Daemon (IDFGH-5736) #7453
Labels
Comments
github-actions
bot
changed the title
Appending questions to MDNS responses breaks Avahi-Daemon
Appending questions to MDNS responses breaks Avahi-Daemon (IDFGH-5736)
Aug 21, 2021
@negativekelvin Thanks for the reference @d8ahazard This bug was fixed as Please update the IDF version to include the above commits. It's also possible to work around this bug setting |
@d8ahazard Could you please close the issue? |
Thanks for reporting, feel free to reopen. |
espressif-bot
added
Resolution: Done
Issue is done internally
Status: Done
Issue is done internally
and removed
Status: Opened
Issue is new
labels
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This is to loop in this library on the discussion being had here:
Aircoookie/WLED#2009 (comment)
and here:
avahi/avahi#348
Basically, the esp-mdns implementation is echoing th question message in responses, which causes avahi-daemon to discard the response as invalid.
I can see this happening here at line 1085:
https://github.com/espressif/esp-idf/blob/master/components/mdns/mdns.c
Apparently, the proper approach as per the RFC for MDNS is to ignore these responses, so it would stand to reason that the behavior on this side is fine, but I just wanted to link it to the other issues for completeness.
The text was updated successfully, but these errors were encountered: