Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for no ports #1204

Merged
merged 1 commit into from
May 31, 2024
Merged

Add validation for no ports #1204

merged 1 commit into from
May 31, 2024

Conversation

radurentea
Copy link
Collaborator

@radurentea radurentea commented May 30, 2024

Description

Fixes bug for "New Project" window.
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Use Command "New Project"
  • Expected behaviour:
    Window should be useable, before this fix, the behaviour was like the one in the screenshot attached above.
  • Expected output:

Test Configuration:

  • ESP-IDF Version: 5.2.1
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this May 30, 2024
Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea
Copy link
Collaborator Author

@AndriiFilippov PTAL

@brianignacio5 brianignacio5 added this to the v1.8.0 milestone May 30, 2024
@AndriiFilippov
Copy link
Collaborator

@radurentea hi !
Tested
LGTM 👍

Just noticed that during port selection it try to connect to the board before port is selected. which is cause this error. it is not critical - everything works, but this will confuse users:

image

@radurentea
Copy link
Collaborator Author

I'm not sure why you get this error, I've tested with c6 board and I had no issue. Maybe you don't have the drivers installed for the board?

@AndriiFilippov
Copy link
Collaborator

ok, I will double check it.
Lets merge this one

@radurentea radurentea merged commit eea5293 into master May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants