Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coldet: vs based modes may place particles outside box #2231

Closed
RudolfWeeber opened this issue Sep 5, 2018 · 2 comments
Closed

Coldet: vs based modes may place particles outside box #2231

RudolfWeeber opened this issue Sep 5, 2018 · 2 comments
Assignees

Comments

@RudolfWeeber
Copy link
Contributor

Yet another corner case:
The vs are initailly placed at the position of one of the colliding particles, to put them in a valid cell for the node.
After all collision are handled, a reosrt occurs, which will put the vs in the correct cell on the correct node.

However: the colliding particle may itself be outside of the node domain by up to a skin.
A possible solution might be to place based on p.l.p_old, since the last verlet update definitely happened at a valid position for the current node.

@fweik
Copy link
Contributor

fweik commented Sep 5, 2018

Why can't you just put it into the same cell as the the colliding particle? The position should not matter.

@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.1 milestone Oct 15, 2018
@RudolfWeeber RudolfWeeber self-assigned this Oct 15, 2018
@fweik fweik changed the title Coldet: vs based modes may place particles outsie box Coldet: vs based modes may place particles outside box Oct 29, 2018
@fweik
Copy link
Contributor

fweik commented Nov 7, 2018

Fixed by #2344.

@fweik fweik closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants