Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Rake with Build CLI Tool in GitHub Action + Improve Caching #2083

Closed
4 tasks
AmmarAbouZor opened this issue Aug 30, 2024 · 1 comment
Closed
4 tasks
Assignees
Labels
new newly created issue

Comments

@AmmarAbouZor
Copy link
Member

After successfully replacing rake with Build CLI Tool in Release workflow, it would great to replace rake in all other workflows as well, since the current implementation of the Build tool supports running in CI pipelines.

Another task would be having a way to have the job Swatinem/rust-cache@v2.7.3 to cache the Build of the CLI Tool to avoid compiling it on each run, similar to installing nj-cli and wasm-pack now.
The main difference is that those tools are registered on crates.io, whereas installing the CLI tool is always locally. We can try to change the build to run from Git URL and hope that will trigger the caching action. Otherwise, we may need to register the tool on crates.io if we want to save about 1.5 Minutes on each GitHub Action

Task:

  • Replace Rake in lint_master.yml
  • Replace Rake in pullrequest_check.yml
  • Remove build_cli_checks.yml
  • Cache CLI Tool binary to reduce building time.
@github-actions github-actions bot added the new newly created issue label Aug 30, 2024
@itsmesamster itsmesamster self-assigned this Sep 2, 2024
@AmmarAbouZor
Copy link
Member Author

Already implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new newly created issue
Projects
None yet
Development

No branches or pull requests

3 participants