You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the context of Jasmine, tests, which should be executed should be detected by filename pattern or by configuration file.
Motivation
As soon as developer adds new Jasmine test, it should not require changes on Build CLI sys.
Way 1. By configuration file
We already have the configuration file application/apps/rustcore/ts-bindings/spec/defaults.json. An additional config file will add useless complexity. At the same time defaults.json doesn't have references to spec files. An additional field with the name of spec file could resolve this issue.
Issues/problems/weak points:
defaults.json supports comments. In the context of Rust it means, that before opening and parsing of file, we should cleanup file from comments.
changing of format defaults.json requires changes of build CLI tool.
Way 2. By file name
We also can list all *.spec.ts / *.spec.js and run tests for just each file.
Issues/problems/weak points:
Some tests like session.benchmark.spec.ts should not be run in a regular way. A possible option - make a naming convention (one of):
*.regular.spec.ts - always run;
*.ignore.spec.ts - ignore, required direct run
Also we can put spec files into different folders:
regular - run in regular way with testing
custom - can be run only directly
An addition configuration file is better to avoid.
My vote for Way 2, but any ideas are welcome.
The text was updated successfully, but these errors were encountered:
In the context of Jasmine, tests, which should be executed should be detected by filename pattern or by configuration file.
Motivation
As soon as developer adds new Jasmine test, it should not require changes on Build CLI sys.
Way 1. By configuration file
We already have the configuration file
application/apps/rustcore/ts-bindings/spec/defaults.json
. An additional config file will add useless complexity. At the same timedefaults.json
doesn't have references tospec
files. An additional field with the name ofspec
file could resolve this issue.Issues/problems/weak points:
defaults.json
supports comments. In the context of Rust it means, that before opening and parsing of file, we should cleanup file from comments.defaults.json
requires changes of build CLI tool.Way 2. By file name
We also can list all
*.spec.ts
/*.spec.js
and run tests for just each file.Issues/problems/weak points:
Some tests like
session.benchmark.spec.ts
should not be run in a regular way. A possible option - make a naming convention (one of):*.regular.spec.ts
- always run;*.ignore.spec.ts
- ignore, required direct runAlso we can put spec files into different folders:
regular
- run in regular way with testingcustom
- can be run only directlyAn addition configuration file is better to avoid.
My vote for
Way 2
, but any ideas are welcome.The text was updated successfully, but these errors were encountered: