Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI check manually with UI option & Improvements #2140

Closed
AmmarAbouZor opened this issue Oct 30, 2024 · 0 comments · Fixed by #2129
Closed

Run CI check manually with UI option & Improvements #2140

AmmarAbouZor opened this issue Oct 30, 2024 · 0 comments · Fixed by #2129
Assignees
Labels
new newly created issue

Comments

@AmmarAbouZor
Copy link
Member

Following improvements and fixes are needed for the current checks for out CI checks for PRs and Master:

  • It would be helpful to start the PR checks manually and choose the preferred UI option for the logs in cargo chipmunk. Available options are print and immediate
  • cargo chipmunk commands for linting and testing shouldn't specify any target, then the tool itself will pick all the needed targets. Currently only some of the targets are specified which resulting in some if the targets being ignored.
  • wasm-pack is installed currently via a script. But we can install it from cargo directly and get the benefits form caching it since we are using cargo-cache action in out pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new newly created issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants