Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build CLI: Include Additional Features in Skip Checks #2152

Closed
AmmarAbouZor opened this issue Nov 20, 2024 · 0 comments · Fixed by #2154
Closed

Build CLI: Include Additional Features in Skip Checks #2152

AmmarAbouZor opened this issue Nov 20, 2024 · 0 comments · Fixed by #2154
Assignees
@AmmarAbouZor
Labels
new newly created issue

Comments

@AmmarAbouZor
Copy link
Member

After introducing the additional features flags in the PR #2147, we got into some cases, where the changes in those features won't be considered if there are no other changes within the target.
This happens because we are not considering the changes on the feature flags in the current skip checks which are based on the changes in source-code files only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmmarAbouZor AmmarAbouZor

Labels
new newly created issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Skip Builds Handling on Build CLI & Disable TLS Initial on Jemalloc AmmarAbouZor/chipmunk
1 participant
@AmmarAbouZor