Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unions: ABI. #881

Open
otrho opened this issue Sep 17, 2024 · 1 comment · May be fixed by #912
Open

Unions: ABI. #881

otrho opened this issue Sep 17, 2024 · 1 comment · May be fixed by #912
Labels
bug 🐛 Something isn't working compiler 🐉 : asm backend json abi 📤

Comments

@otrho
Copy link
Contributor

otrho commented Sep 17, 2024

#872 introduced a WIP implementation of unions. It included parsing and semantic analysis, and some ASM gen. It did not implement ABI support, nor storage support. The ASM gen is essentially untested and requires validation_tests.
@otrho otrho changed the title Unions ABI. Unions: ABI and ASM testing. Sep 17, 2024
@otrho otrho changed the title Unions: ABI and ASM testing. Unions: ABI ~and ASM testing~. Sep 26, 2024
@otrho otrho changed the title Unions: ABI ~and ASM testing~. Unions: ABI. Sep 26, 2024
@otrho
Copy link
Contributor Author

otrho commented Sep 26, 2024

#897 added ASM testing, but fudged the ABI.

@mohammadfawaz mohammadfawaz linked a pull request Oct 8, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working compiler 🐉 : asm backend json abi 📤
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unions abi wip essential-contributions/pint
1 participant
@otrho