Save analysis is gone, migrate to SCIP

[est31]

save-analysis is going away. For the short to mid term future, we can pin nightlies but with increased MSRV requirements, this will cause issues.

Some more info on it in this reddit thread.

[b-zee]

Just wanted to come here to say I bumped into this when attempting to use this tool. save-analysis appears to have been removed last week, so I expect more people coming to this tool and running into a wall.

[est31]

Yeah you will have to use a pinned older nightly, until I find time to migrate to SCIP. It's obviously not a trivial effort.

[b-zee]

Yes, sorry if that came across as rude. This tool was perfect for my use case today. I can imagine it's not an easy task to migrate. Thanks a lot for your past work on this!

[est31]

@b-zee no need to worry, you weren't rude or anything. ❤️

[Matt3o12]

Yeah you will have to use a pinned older nightly, until I find time to migrate to SCIP. It's obviously not a trivial effort.

Do you know which nightly release is the newest that still has save-analysis?

[est31]

@Matt3o12 I'd try the 2023 February 15 or 16 binary, judging by this.

[lsunsi]

I was so happy I found this crate, and then I saw it needed work to keep working. What does this migration entail? I don't think I have anything to offer, but I'd greatly benefit from having unused check across crates, so I want to at least subscribe to this.

[est31]

The algorithmic part of this crate is rather small, most of it is in the parsing of the save analysis. So it would amount to a rewrite really.

[fenollp]

Is there a somewhat detailed plan that splits the move to SCIP in smaller parts? I'd like to get involved.

Finding dead code across crates sounds very useful to us :)

[est31]

@fenollp your bump of this issue, and me wanting to fix it for a long time, has led me to actually work on it. I've pushed the new scip backend to master. Haven't tried it on anything big yet. enjoy.

[b-zee]

Thanks a lot for the refactor, @est31! 🎉 Will try it soon.

[cpg314]

FYI, in the meantime I had an alternative implementation at https://github.com/cpg314/cargo-workspace-unused-pub, tested on a fairly large workspace. It would be interesting to see how they compare. I'll update the README to mention the new SCIP backend of warnalyzer.