-
Notifications
You must be signed in to change notification settings - Fork 335
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build escodegen.browser.js or the minimized equivalent #397
Comments
After playing more with it, I found that using commonjs-everywhere cannot turn the node.js module to a browser-compatible JS library, at least not a standard (i.e. browser independent) one. I observed 2 issues:
I ended up using another tool 'browserify' to convert the js file and it worked perfectly on my Chrome. Haven't tried it on other browsers yet but it should not too much of an issue. README.RD and package.json may be updated to include this recommendation. |
I figured it out and the reasons:
A. escodegen build depend on the 'cjsify' tool which is part of the commonjs-everywhere npm package.
B. The npm installed version of escodegen does not have the tools/ folder, which the build requires.
These details are currently not specified in the README.MD file. I recommend to add the following to the file:
This will make it more clear for new users.
The text was updated successfully, but these errors were encountered: