momentjs causing problems due to bug with $watch in angular.js

[etodanik]

Before submitting a pull request for this one, I'd like to check out the viability of this being accepted.

If you use momentjs in the filters, hell breaks loose due to a peculiarity of angular.copy, which right now copies the prototype rather than reusing it:
angular/angular.js#3767
angular/angular.js#5063

A slight change to ng-table can prevent moment.js from wearing havoc:

$scope.$watch('params.$params | json', function (newParams, oldParams) {
        $scope.params.settings().$scope = $scope;

        if (!angular.equals(JSON.parse(newParams).filter, JSON.parse(oldParams).filter)) {
            delayFilter(function () {
                $scope.params.$params.page = 1;
                $scope.params.reload();
            }, $scope.params.settings().filterDelay);
        } else {
            $scope.params.reload();
        }
    }, true);

What I'm doing here is watching JSON.stringify-ed params, rather than the objects, to prevent the angular.copy issue from running unlimited refreshes.

I'm not quite sure if this is the kind of change one would like to make in a library, however moment.js is a pretty widely adopted library, and it would make sense to be able to anticipate it's use in filter properties.

[petebacondarwin]

angular.copy is now fixed in master so perhaps you can close this?

[etodanik]

correct, thank you very much ! :) you're sort of omnipotent, aren't you?