Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fragile (ou régression Elixir 1.17 / OTP 27) #4217

Open
Tracked by #4216
thbar opened this issue Sep 23, 2024 · 1 comment
Open
Tracked by #4216

Test fragile (ou régression Elixir 1.17 / OTP 27) #4217

thbar opened this issue Sep 23, 2024 · 1 comment
Labels
dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité

Comments

@thbar
Copy link
Contributor

thbar commented Sep 23, 2024

Observé en travaillant sur:

  1) test quality indicators chart is displayed (TransportWeb.DatasetControllerTest)
     apps/transport/test/transport_web/controllers/dataset_controller_test.exs:599
     Assertion with == failed
     code:  assert [
              {"table", [{"class", "table"}],
               [
                 {"tr", [], [{"th", [], ["Conformité"]}, {"th", [], ["Fraicheur"]}]},
                 {"tr", [], [{"td", [], ["80%"]}, {"td", [], ["55%"]}]}
               ]}
            ] == content |> Floki.find("#quality-indicators table")
     left:  [{"table", [{"class", "table"}], [{"tr", [], [{"th", [], ["Conformité"]}, {"th", [], ["Fraicheur"]}]}, {"tr", [], [{"td", [], ["80%"]}, {"td", [], ["55%"]}]}]}]
     right: [{"table", [{"class", "table"}], [{"tr", [], [{"th", [], ["Fraicheur"]}, {"th", [], ["Conformité"]}]}, {"tr", [], [{"td", [], ["55%"]}, {"td", [], ["80%"]}]}]}]
     stacktrace:
       test/transport_web/controllers/dataset_controller_test.exs:636: (test)

Je ne sais pas à ce stade si c'est une régression lié aux upgrades techniques, ou un test déjà fragile avant.

@thbar thbar added the dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité label Sep 23, 2024
@thbar
Copy link
Contributor Author

thbar commented Nov 12, 2024

Ça semble bien, en relisant l'erreur, être un souci d'ordre, typique des changements de fonctionnement des maps avec OTP. Je garde ouvert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité
Projects
None yet
Development

No branches or pull requests

1 participant