Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a client can panic etcd by passing invalid utf-8 in the client-api-version header #13553

Closed
rtmrtmrtmrtm opened this issue Dec 22, 2021 · 0 comments · Fixed by #13560
Closed

Comments

@rtmrtmrtmrtm
Copy link

newUnaryInterceptor() calls prometheus's WithLabelValues() on the
client-supplied client-api-version header value. WithLabelValues()
panics if the value is not valid utf-8.

I've attached a program that sends such a value to the etcd on localhost.

I've attached the resulting etcd output and backtrace.

csh# etcd/bin/etcd --version
running etcd on unsupported architecture "riscv64" since ETCD_UNSUPPORTED_ARCH is set
etcd Version: 3.5.1
Git SHA: d42e858
Go Version: go1.16.2
Go OS/Arch: linux/riscv64

etcd_2.c.txt
etcd_2.out.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant