-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add test cases to cover the case that client api version is not valid UTF-8 string #13592
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Hey @ahrtr - I can see this help wanted issue has been open for a while, I'm keen to give it a go. For the unit test for this would you be adding a new Lastly - can you give me some guidance on how you might approach this, just rough outline/overview would be really helpful as this would be first test case contribution, thanks! |
Probably we can intentionally create an invalid version on client side? We might need an e2e or integration test. |
Closing after discussion with maintainers this is not a priority to progress at the moment. We can revisit and reopen in future if that changes. |
This is a supplement task for pull/13560
The text was updated successfully, but these errors were encountered: