Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add test cases to cover the case that client api version is not valid UTF-8 string #13592

Closed
ahrtr opened this issue Jan 13, 2022 · 6 comments

Comments

@ahrtr
Copy link
Member

ahrtr commented Jan 13, 2022

This is a supplement task for pull/13560

@stale
Copy link

stale bot commented Apr 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 13, 2022
@serathius serathius removed the stale label Apr 13, 2022
@stale
Copy link

stale bot commented Jul 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@jmhbnz
Copy link
Member

jmhbnz commented Mar 18, 2023

Hey @ahrtr - I can see this help wanted issue has been open for a while, I'm keen to give it a go.

For the unit test for this would you be adding a new etcdserver/api/v3rpc/interceptor_test.go file or would you include this new test in an existing file elsewhere?

Lastly - can you give me some guidance on how you might approach this, just rough outline/overview would be really helpful as this would be first test case contribution, thanks!

@ahrtr
Copy link
Member Author

ahrtr commented Mar 18, 2023

Lastly - can you give me some guidance on how you might approach this, just rough outline/overview would be really helpful as this would be first test case contribution, thanks!

Probably we can intentionally create an invalid version on client side? We might need an e2e or integration test.

@jmhbnz
Copy link
Member

jmhbnz commented Mar 20, 2023

Initial pull request covering one scenario is here #15537. I think we need a second test covering a scenario that potentially sidesteps clientv3 altogether.

/assign @jmhbnz

@jmhbnz
Copy link
Member

jmhbnz commented Apr 11, 2023

Closing after discussion with maintainers this is not a priority to progress at the moment. We can revisit and reopen in future if that changes.

@jmhbnz jmhbnz closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
@jmhbnz jmhbnz removed their assignment Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants