Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Enhance (*ExpectProcess) ExpectFunc #14638

Closed
ahrtr opened this issue Oct 27, 2022 · 5 comments
Closed

[test] Enhance (*ExpectProcess) ExpectFunc #14638

ahrtr opened this issue Oct 27, 2022 · 5 comments
Labels
help wanted type/feature

Comments

@ahrtr
Copy link
Member

ahrtr commented Oct 27, 2022

What would you like to be added?

Please read https://github.com/etcd-io/etcd/pull/14574/files#r1007427389

Why is this needed?

See link above
@ahrtr ahrtr mentioned this issue Oct 27, 2022
Merged
@serathius
Copy link
Member

+1 for short running commends like etcdctl we should wait till commands exits instead of waiting for specific log.

@tjungblu
Copy link
Contributor

tjungblu commented Nov 1, 2022

prepared something in #14672, let me know what you guys think.

@halegreen
Copy link
Contributor

@tjungblu hi, are you still working on this ?

@tjungblu
Copy link
Contributor

tjungblu commented Nov 7, 2022

yep, I'm busy with some downstream work for the next couple of days, but I pick it up again on Thursday.

@ahrtr
Copy link
Member Author

ahrtr commented Jan 18, 2023

Completed in #14672

@ahrtr ahrtr closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type/feature
Milestone
No milestone
Development

No branches or pull requests
4 participants
@serathius @halegreen @ahrtr @tjungblu