Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add verify-goimport to verify all import items are well sorted. #15469

Closed
ahrtr opened this issue Mar 13, 2023 · 4 comments
Closed

add verify-goimport to verify all import items are well sorted. #15469

ahrtr opened this issue Mar 13, 2023 · 4 comments
Assignees
@HanningLin
Labels
good first issue help wanted type/feature

Comments

@ahrtr
Copy link
Member

ahrtr commented Mar 13, 2023

What would you like to be added?

We have go_imports_fix, but we don't have related verification.

Let's add a verify-goimport in Makefile#L46 to prevent #15467 from happening again in future.

Why is this needed?

Improve test workflow
@HanningLin
Copy link
Contributor

I'd like to work on it and contribute to etcd!

@ahrtr
Copy link
Member Author

ahrtr commented Mar 14, 2023

Thanks. Just assigned to you. @HanningLin

@ahrtr ahrtr mentioned this issue Mar 15, 2023
Merged
@HanningLin HanningLin mentioned this issue Mar 16, 2023
Merged
@HanningLin
Copy link
Contributor

Can we close this issue?

@ahrtr
Copy link
Member Author

ahrtr commented Mar 17, 2023

Resolved in #15485

@ahrtr ahrtr closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HanningLin HanningLin

Labels
good first issue help wanted type/feature
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HanningLin @ahrtr