Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the TestInPlaceRecovery when cluster proxy is enabled #16690

Open
serathius opened this issue Oct 4, 2023 · 5 comments
Open

Fix the TestInPlaceRecovery when cluster proxy is enabled #16690

serathius opened this issue Oct 4, 2023 · 5 comments

Comments

@serathius
Copy link
Member

What would you like to be added?

Followup from #16677

Why is this needed?

Keep the same test coverage with cluster proxy

@pawandeep2155
Copy link

I am starting to work on this issue. Thanks.

@pawandeep2155
Copy link

@serathius Can you give some details on what all needs to be changed so that it's easy for me to get started?

@serathius
Copy link
Member Author

In #16677 I have added //go:build !cluster_proxy to tests/e2e/corrupt_test.go. This disables building this file when cluster_proxy label is used, meaning that all tests in this file are disabled in cluster proxy scenario. I did it because the changes to TestInPlaceRecovery didn't work with cluster_proxy.

What we want to do:

  • Restore testing cluster_proxy for tests in tests/e2e/corrupt_test.go. This can be quickly done by moving TestInPlaceRecovery test to separate file.
  • Debug why TestInPlaceRecovery test doesn't work with cluster_proxy and investigate if we can fix it.

@serathius
Copy link
Member Author

With #16637 we would also want to backport this to release-3.5 branch.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants