Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pre-vote flag #17328

Closed
serathius opened this issue Jan 26, 2024 · 6 comments · Fixed by #17762
Closed

Document pre-vote flag #17328

serathius opened this issue Jan 26, 2024 · 6 comments · Fixed by #17762
Labels
area/documentation help wanted priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@serathius
Copy link
Member

What would you like to be added?

Current flag documentation in command line:

  --pre-vote 'true'
    Enable to run an additional Raft election phase.

From the original PR #9352

Why is this needed?

Users are not aware of this feature #17326. Expect lack of proper documentation is the main reason.

@UtkarshUmre
Copy link

@serathius What needs to be done to resolve this issue?Is this a good first issue?

@serathius
Copy link
Member Author

serathius commented Jan 30, 2024

Read the feature description in #9352 and improve the existing command line documentation for the flag

fs.BoolVar(&cfg.PreVote, "pre-vote", cfg.PreVote, "Enable to run an additional Raft election phase.")

Basically expand the text Enable to run an additional Raft election phase.

Is this a good first issue?

Depends, no coding but it requires a good understanding of raft protocol.

@UtkarshUmre
Copy link

I understand, and I will look more into this before raising a pull request soon. Where can I find more information about the Raft protocol?

@serathius
Copy link
Member Author

serathius commented Jan 31, 2024

@jmhbnz jmhbnz added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 14, 2024
@shreemaan-abhishek
Copy link
Contributor

I would like to take this up.

@nitishfy
Copy link
Contributor

Hi there, If possible, I'd like to work on this:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation help wanted priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Development

Successfully merging a pull request may close this issue.

5 participants