Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use http.Request.WithContext instead of Cancel #6953

Closed
heyitsanthony opened this issue Dec 6, 2016 · 5 comments
Closed

use http.Request.WithContext instead of Cancel #6953

heyitsanthony opened this issue Dec 6, 2016 · 5 comments
Milestone
v3.2.0

Comments

@heyitsanthony
Copy link
Contributor

Available as of 1.7
@heyitsanthony heyitsanthony added this to the v3.2.0 milestone Dec 6, 2016
@xiang90
Copy link
Contributor

xiang90 commented Jan 27, 2017

@sinsharat Can you help to fix this? We have a bunch of places using our own context to cancel http request. We can use https://golang.org/pkg/net/http/#Request.WithContext directly. This issue might take you some time to finish since we have http related code throughout the codebase. but you can start from rafthttp.

@sinsharat
Copy link
Contributor

@xiang90 Sure will start looking into it.
Thanks!

This was referenced Jan 31, 2017
Merged
Merged
@xiang90
Copy link
Contributor

xiang90 commented Feb 2, 2017

closed by #7269 + #7255

@xiang90 xiang90 closed this as completed Feb 2, 2017
@xiang90
Copy link
Contributor

xiang90 commented Feb 2, 2017

@sinsharat Thanks a lot for taking care of this!

@sinsharat
Copy link
Contributor

@xiang90 you are most welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
v3.2.0
Development

No branches or pull requests
3 participants
@xiang90 @heyitsanthony @sinsharat