Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print out the request detail when it takes too long to process #9111

Closed
xiang90 opened this issue Jan 8, 2018 · 2 comments · Fixed by #9288
Closed

print out the request detail when it takes too long to process #9111

xiang90 opened this issue Jan 8, 2018 · 2 comments · Fixed by #9288

Comments

@xiang90
Copy link
Contributor

xiang90 commented Jan 8, 2018

We print out a warning if some requests take more than 100ms to execute. However, we do not print out the details of these requests, which make it harder for users to locate the bad requests.

We can do a better job to print it out in etcdserver/apply.go, and also add metrics around apply duration.

@xiang90 xiang90 added this to the v3.4.0 milestone Jan 8, 2018
@hexfusion
Copy link
Contributor

@xiang90 this looks interesting, do you think it would make sense for me to take a look at this?

@xiang90
Copy link
Contributor Author

xiang90 commented Jan 8, 2018

@hexfusion

sure. right now the printing is at here:https://github.com/coreos/etcd/blob/master/etcdserver/server.go#L800-L804. it is too coarse grind.

you can trigger this warning by range over 100k keys in one range request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants