Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code using mvccpb.KeyValue fail to compile #9293

Closed
kaoet opened this issue Feb 7, 2018 · 2 comments
Closed

Code using mvccpb.KeyValue fail to compile #9293

kaoet opened this issue Feb 7, 2018 · 2 comments

Comments

@kaoet
Copy link

kaoet commented Feb 7, 2018

After 80d1594, code using mvccpb.KeyValue explicitly fail to compile since it is moved into internal directory.

mvccpb.KeyValue is export as field type of github.com/coreos/etcd/etcdserver/etcdserverpb.RangeResponse.Kvs. Since RangeResponse is a public API. mvccpb.KeyValue should be public, too.
@gyuho
Copy link
Contributor

gyuho commented Feb 7, 2018

Plan was revert that change #9274, until we find better way to handle internal packages. /cc @xiang90

@chen-anders chen-anders mentioned this issue Feb 10, 2018
Open
@hexfusion hexfusion mentioned this issue Feb 10, 2018
Closed
@gyuho
Copy link
Contributor

gyuho commented Feb 27, 2018

@kaoet Sorry for late response. We've reverted the changes for now. Please try the master branch.

@gyuho gyuho closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaoet @gyuho