-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Go 1.10.x for 3.3 release to support crypto/x509 "name constraints" #9912
Comments
@cultcom, thank you for the report. |
@cultcom We will use Go 1.10 or 1.11 for 3.4 release, which is a few months away. And we do not bump up Go versions in our stable release branches. Are you trying to use name constraints in production? |
well, the locally used CA had them configured but now I deactivated that until etcd comes compiled with golang 1.10 ;-) |
@cultcom Could you try building release-3.3 branch with latest Go 1.10 and see if it resolves your issue? Then, we will try benchmark 3.3 branch with Go 1.10 to see if it would introduce any regressions. If numbers looks good, we should be safe to bump up Go version in 3.3 releases. |
@gyuho Yes, I did that yesterday and it fixed the issue: I build the official 3.3.8 source package from github (not the cloned repo). FYI: Ubuntu 18.04 comes officially with 3.2.17 which is compiled with golang 1.10. |
@cultcom Thanks. We will try bumping up the Go version in the next 3.3 release. |
@gyuho Thanks. |
Better performance with Go 1.10 as well. Will set Go version to 1.10 in our 3.3 branch. |
The official etcd binaries found on github.com are compiled with golang version 1.9:
~# etcd --version
etcd Version: 3.3.8
Git SHA: 33245c6
Go Version: go1.9.7
Go OS/Arch: linux/amd64
Unfortunately this golang version does not support nameConstraints correctly according to golang/go#15196
So please update your build process to utilize golang 1.10 for further releases.
The text was updated successfully, but these errors were encountered: