Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[design]: add internal package to hide our implementation details #15

Closed
skyao opened this issue Jul 22, 2016 · 2 comments
Closed

[design]: add internal package to hide our implementation details #15

skyao opened this issue Jul 22, 2016 · 2 comments

Comments

@skyao
Copy link
Contributor

skyao commented Jul 22, 2016 •
edited
Loading

I would like to add a internal package such as "com.coreos.jetcd.internal" and move some implementation classes like EtcdKVImpl to it.

And we should document that all the classes in package internal are our internal implementation detail and should not be used directly.

Then We can update them freely.
@adohe-zz
Copy link

@skyao I already have a design proposal when I try to implement this client, you may take a look.

@fanminshi
Copy link
Member

"com.coreos.jetcd.internal" is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adohe-zz @skyao @fanminshi