Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcustomscrollbar breaks chat inside cross-domain iframe #52

Closed
luxaritas opened this issue Aug 21, 2017 · 6 comments
Closed

mcustomscrollbar breaks chat inside cross-domain iframe #52

luxaritas opened this issue Aug 21, 2017 · 6 comments

Comments

@luxaritas
Copy link
Member

We planned for www.eternagame.org to (temporarily) load the chat from irc.eternagame.org as an iframe. A bug in the custom scrollbar causes an error when this happens.

There is a patch for this at malihu/malihu-custom-scrollbar-plugin#451, but apparently, the repo is not maintained. Should we fork it and merge in the fix (@Omei, I think this would be up to you)? Or should we use a different library? This will be replaced once the rewrite happens anyhow (assuming we use Vue, we should ditch jQuery as a dependency).

@luxaritas
Copy link
Member Author

@guyguy2001
Copy link
Contributor

May I patch any of them in? If so, are there any preferences to which?

@luxaritas
Copy link
Member Author

@guyguy2001 Preferences to which what?

@guyguy2001
Copy link
Contributor

Which library to use

@luxaritas
Copy link
Member Author

Frankly, what I care about is that it works and it looks ok. :)

@luxaritas
Copy link
Member Author

Resolved in 3201bac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants