Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web3 to be compatible with web3-flashbots #1048

Closed
BlinkyStitt opened this issue Apr 13, 2021 · 4 comments
Closed

Update web3 to be compatible with web3-flashbots #1048

BlinkyStitt opened this issue Apr 13, 2021 · 4 comments

Comments

@BlinkyStitt
Copy link
Collaborator

Overview

I am wanting to use https://github.com/flashbots/web3-flashbots.git with a brownie project.

However, I get this error when trying to install both:

The conflict is caused by:
    eth-brownie 1.14.4 depends on web3==5.11.1
    flashbots 0.3.0 depends on web3<6.0.0 and >=5.17.0

Specification

Can we upgrade the web3 in brownie to >=5.17.0?

Any known blockers on that? I half remember web3 upgrades being difficult.

@BlinkyStitt
Copy link
Collaborator Author

For now, I think I might be able to do export BROWNIE_LIB=1

@BlinkyStitt BlinkyStitt changed the title Update web3 Update web3 to be compatible with flashbots Apr 13, 2021
@BlinkyStitt BlinkyStitt changed the title Update web3 to be compatible with flashbots Update web3 to be compatible with web3-flashbots Apr 13, 2021
@BlinkyStitt
Copy link
Collaborator Author

export BROWNIE_LIB=1 is working for me

@BlinkyStitt
Copy link
Collaborator Author

BlinkyStitt commented Apr 13, 2021

Actually that upgrades too much and breaks brownie test. I'm trying now with running pip-compile --upgrade-package web3 for brownie (and pip-compile --upgrade-package web3 requirements-dev.in and pip-compile --upgrade-package web3 requirements-windows.in .

@iamdefinitelyahuman
Copy link
Member

Fixed by #1064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants