Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brownie defaults to compiling with istanbul for vyper #1613

Open
mhorsley30896 opened this issue Sep 21, 2022 · 3 comments
Open

brownie defaults to compiling with istanbul for vyper #1613

mhorsley30896 opened this issue Sep 21, 2022 · 3 comments

Comments

@mhorsley30896
Copy link

mhorsley30896 commented Sep 21, 2022

Environment information

  • brownie Version: 1.19.1
  • vyper Version: 0.3.6

What was wrong?

brownie defaults to compiling with evm_version = "istanbul" for vyper

evm_version = "istanbul"

this version is now behind the one used by default for the vyper compiler

this causes brownie compile and vyper compilation bytecode to be different, causing issues with source code verification

How can it be fixed?

Instead of hardcoding the evm_version read the version used by the installed vyper version

@dejanko25
Copy link

Hey, this sounds interesting.
I will look into this further.

@chanhosuh
Copy link

Vyper's default currently is "paris". I don't believe brownie or ganache supports that. I found this works fine in my case (set in brownie config):

compiler:
  evm_version: berlin

@magnetto90
Copy link

What about solidity? It should also be able to select paris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants