Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brownie test ist broken after upgrade to ganache 7.7.0 #1644

Open
doerfli opened this issue Dec 16, 2022 · 0 comments
Open

Brownie test ist broken after upgrade to ganache 7.7.0 #1644

doerfli opened this issue Dec 16, 2022 · 0 comments

Comments

@doerfli
Copy link

doerfli commented Dec 16, 2022

Environment information

  • brownie Version: 1.19.2
  • ganache-cli Version: 7.7.0
  • solc Version: 0.8.2
  • Python Version: 3.9.16
  • OS: linux

What was wrong?

After update of ganache npm package to 7.7.0 (which was released yesterday), the test execution (brownie test) fails with this error (for almost every test)

_____________________ test_price_price_id_sequence_repeat ______________________
[gw0] linux -- Python 3.9.16 /opt/pipx/venvs/eth-brownie/bin/python

usdc_feeder = <UsdcPriceDataProvider Contract '0xF12b5dd4EAD5F743C6BaA640B0216200e89B60Da'>

    def test_price_price_id_sequence_repeat(usdc_feeder: UsdcPriceDataProvider):
    
        if web3.chain_id != GANACHE:
            print('unsupported test case for chain_id {}'.format(web3.chain_id))
    
        for i, data in enumerate(USDC_CHAINLINK_DATA_PRICE_SEQUENCE_REPEAT):
            inject_data(usdc_feeder, data)
    
            print('data[{}] {}'.format(i, data))
    
            # roundid 36893488147419103822
            if i in [0, 1]:
                # tx = usdc_feeder.getPriceInfo(price_id)
                tx = usdc_feeder.processLatestPriceInfo()
>               price_info = tx.return_value.dict()
E               TypeError: int() can't convert non-string with explicit base

tests/test_aggregator_usdc.py:171: TypeError
----------------------------- Captured stdout call -----------------------------
data[0] 36893488147419103822 100000017 1660[29](https://github.com/etherisc/depeg-contracts/actions/runs/3712425152/jobs/6293941137#step:9:30)7[30](https://github.com/etherisc/depeg-contracts/actions/runs/3712425152/jobs/6293941137#step:9:31)6 1660297306 3689[34](https://github.com/etherisc/depeg-contracts/actions/runs/3712425152/jobs/6293941137#step:9:35)8814741910[38](https://github.com/etherisc/depeg-contracts/actions/runs/3712425152/jobs/6293941137#step:9:39)22

Tests that fails: https://github.com/etherisc/depeg-contracts/blob/develop/tests/test_aggregator_usdc.py#L171

How can it be fixed?

Downgrade brownie to 7.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant