Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta parameter from strategy #15

Closed
kabicm opened this issue Sep 3, 2019 · 1 comment
Closed

Remove beta parameter from strategy #15

kabicm opened this issue Sep 3, 2019 · 1 comment
Assignees

Comments

@kabicm
Copy link
Collaborator

kabicm commented Sep 3, 2019

Currently, beta parameter in strategy is of type double (thus not templated). However, there is no need for strategy to contain this parameter. Strategy has to be decoupled from the command line parser (options) and beta should be removed from strategy.

@kabicm kabicm self-assigned this Sep 3, 2019
@kabicm
Copy link
Collaborator Author

kabicm commented Mar 7, 2020

Resolved in commit #97751914c43ba3044dda7a58c9a14efda38e7149

The beta parameter is now removed from the strategy. It was mostly used in the buffer class. However, it was only used as an indicator of whether additional reduce buffers are going to be allocated. To make it independent of the beta parameter, we set this value to 1, so that buffers will always allocate additional reduce buffer. This makes sense because for the same matrices the user might want to run different multiplications and the buffer class, as well as the matrix class, should be independent of beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant